Create /etc/thelounge directory with 0700 permissions #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sensitive information is protected by thelounge/thelounge#205 for Docker builds, but deb installs didn't benefit, due to the home dir already existing - created at build time.
awfulcooking
added a commit
to awfulcooking/thelounge
that referenced
this pull request
Sep 5, 2021
Helps to prevent and retrospectively address issues like thelounge/thelounge-deb#72 Obviously some sysadmins may want the directory to be world-readable, but presently, that isn't safe. This commit could be omitted or later reverted if sensitive data protection is ensured through other means - e.g. with patches for existing files, and an emphasis at review time to catch over-exposure in the future ✌
|
700 is overkill, certainly for the top level config folder |
|
if you want to guard against logs / vapid to be readable, fix those instead please |
|
Logs / vapid ought to be addressed on their own too, but the effect of
their oversight is prevented by the choice to chmod the top level to
700 by default, which was deemed prudent at the time
It's implemented generically in thelounge/thelounge, rather than
thelounge/thelounge-docker, so it seemed like it was unintentional that
it didn't take effect for .deb builds
…On Sun, Sep 5 2021 at 01:21:47 -0700, Reto ***@***.***> wrote:
if you want to guard against logs / vapid to be readable, fix those
instead please
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensitive information is protected by thelounge/thelounge#205 for Docker builds, but deb installs didn't benefit, due to the home dir already existing - created at build time.